Skip to content

Hide config validation warnings; round OPS and use separators for thousands #2286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jnioche merged 1 commit into from
Oct 29, 2026
Merged

Hide config validation warnings; round OPS and use separators for thousands #2286

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 11 additions & 7 deletions core/src/main/java/org/apache/stormcrawler/persistence/StatusUpdaterBenchmark.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,6 +190,8 @@ public static void main(String[] args) throws Exception {

// log4j is what storm local uses, the INFO messages of the bolts would drown the reports
Configurator.setAllLevels(LogManager.ROOT_LOGGER_NAME, Level.WARN);
// storm local warns about a deprecated config set in Storm's own defaults.yaml
Configurator.setLevel("org.apache.storm.validation.ConfigValidation", Level.ERROR);

Config conf = new Config();
conf.putAll(
Expand Down Expand Up @@ -265,10 +267,10 @@ public static void main(String[] args) throws Exception {
long delta = current - lastAcked.getAndSet(current);
System.out.printf(
Locale.ROOT,
"Acked: %d - OPS over the last %d sec: %.2f%n",
"Acked: %,d - OPS over the last %d sec: %,d%n",
current,
Math.round(elapsed / 1000.0),
delta * 1000.0 / Math.max(1, elapsed));
Math.round(delta * 1000.0 / Math.max(1, elapsed)));
},
REPORT_INTERVAL_SEC,
REPORT_INTERVAL_SEC,
Expand Down Expand Up @@ -330,12 +332,14 @@ public static void main(String[] args) throws Exception {

System.out.println("Instances: " + instances);
System.out.println("Parsers: " + parsers);
System.out.println("Sent: " + sent);
System.out.println("Acked: " + collector.acked.get());
System.out.println("Failed: " + collector.failed.get());
System.out.println("Total time: " + elapsed + " msec");
System.out.printf(Locale.ROOT, "Sent: %,d%n", sent);
System.out.printf(Locale.ROOT, "Acked: %,d%n", collector.acked.get());
System.out.printf(Locale.ROOT, "Failed: %,d%n", collector.failed.get());
System.out.printf(Locale.ROOT, "Total time: %,d msec%n", elapsed);
System.out.printf(
Locale.ROOT, "Average OPS: %.2f%n", collector.acked.get() * 1000.0 / elapsed);
Locale.ROOT,
"Average OPS: %,d%n",
Math.round(collector.acked.get() * 1000.0 / elapsed));

// some backends leave non-daemon threads behind
System.exit(collector.acked.get() == sent ? 0 : 1);
Expand Down
Loading