Repository navigation
Hide config validation warnings; round OPS and use separators for thousands - #2286
Merged
Merged
Conversation
…usands Signed-off-by: Julien Nioche <julien@digitalpebble.com>
rzo1
approved these changes
Oct 29, 2026
rzo1
left a comment
rzo1
left a comment
Contributor
There was a problem hiding this comment.
Shouldnt we fill and fix upstream?
Contributor
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Running the benchmarks with storm 3.1.0 generates loads of warnings like
09:24:09.966 [AsyncLocalizer Task Executor - 1] WARN o.a.s.v.ConfigValidation - nimbus.supervisor.timeout.secs is a deprecated config please see class org.apache.storm.DaemonConfig.NIMBUS_SUPERVISOR_TIMEOUT_SECS for more information.These are now silenced.
We also make the outputs easier to read by using commas as separators for long numbers and round the OPS to integers