Skip to content

Test fix: flaky doc-order assertions in TextToVectorUpdateProcessorTest #4879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dsmiley wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −4
Open

Test fix: flaky doc-order assertions in TextToVectorUpdateProcessorTest #4879

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions ...test/org/apache/solr/languagemodels/update/processor/TextToVectorUpdateProcessorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,9 @@ private SolrQuery getSolrQuery() {
final SolrQuery query = new SolrQuery();
query.setQuery(solrQuery);
query.add("fl", "id,vector");
// *:* gives every doc the same score, so without an explicit sort the order between
// tied docs is arbitrary (depends on segment/merge timing), which made this flaky.
query.setSort("id", SolrQuery.ORDER.desc);
return query;
}

Expand Down Expand Up @@ -187,10 +190,10 @@ public void processAtomicUpdate_shouldTriggerTheVectorizationAndFetchTheStoredCo
assertJQ(
"/query" + query.toQueryString(),
"/response/numFound==2]",
"/response/docs/[0]/id=='98'",
"!/response/docs/[0]/vector==", // no vector field for document 98
"/response/docs/[1]/id=='99'",
"/response/docs/[1]/vector==[1.0, 2.0, 3.0, 4.0]");
"/response/docs/[0]/id=='99'",
"/response/docs/[0]/vector==[1.0, 2.0, 3.0, 4.0]",
"/response/docs/[1]/id=='98'",
"!/response/docs/[1]/vector=="); // no vector field for document 98

restTestHarness.delete(TextToVectorModelStore.REST_END_POINT + "/dummy-1");
}
Expand Down
Loading