Test fix: flaky doc-order assertions in TextToVectorUpdateProcessorTest - #4879
Open
dsmiley wants to merge 1 commit into
Open
Test fix: flaky doc-order assertions in TextToVectorUpdateProcessorTest#4879dsmiley wants to merge 1 commit into
dsmiley wants to merge 1 commit into
Conversation
The test's shared query helper ran `q=*:*` with no sort. Since *:* gives every doc the same score, the order between tied docs 98 and 99 was resolved by internal segment/merge timing rather than anything Solr guarantees -- causing intermittent failures under contended workers (e.g. crave, `-XX:ActiveProcessorCount=1`). Add an explicit `sort=id desc` to make ordering deterministic, and swap the expected doc order in processAtomicUpdate_shouldTriggerTheVectorizationAndFetchTheStoredContent, whose assertions had been keyed to the opposite (accidental) order. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019n8pzT7WWNwf76ackKPyv3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test's shared query helper ran
q=*:*with no sort. Since : gives every doc the same score, the order between tied docs 98 and 99 was resolved by internal segment/merge timing rather than anything Solr guarantees -- causing intermittent failures under contended workers.Add an explicit
sort=id descto make ordering deterministic, and swap the expected doc order inprocessAtomicUpdate_shouldTriggerTheVectorizationAndFetchTheStoredContent, whose assertions had been keyed to the opposite (accidental) order.
found & fixed with AI