Skip to content

fix: correct formatting and release version parsing #156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zjw1111 wants to merge 2 commits into
base: main
Choose a base branch
from
+5 −6
Open

fix: correct formatting and release version parsing #156

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4bb95ee
style: apply cmake-format to examples
zjw1111 Jul 24, 2026
9af9938
fix: make release version parsing portable
zjw1111 Jul 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion examples/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,8 @@ if(TARGET Arrow::arrow_shared)
elseif(TARGET Arrow::arrow_static)
set(PAIMON_EXAMPLE_ARROW_TARGET Arrow::arrow_static)
else()
message(FATAL_ERROR "Neither Arrow::arrow_shared nor Arrow::arrow_static is available")
message(FATAL_ERROR "Neither Arrow::arrow_shared nor Arrow::arrow_static is available"
)
endif()

add_executable(read_write_demo read_write_demo.cpp)
Expand Down
3 changes: 1 addition & 2 deletions scripts/releasing/create_source_release.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,8 +115,7 @@ done

CMAKE_VERSION=$(
git -C "${SOURCE_ROOT}" show "${GIT_REF}:CMakeLists.txt" |
sed -n 's/^[[:space:]]*VERSION[[:space:]]\+\([0-9][0-9.]*\).*$/\1/p' |
head -n 1
awk '$1 == "VERSION" && $2 ~ /^[0-9]+\.[0-9]+\.[0-9]+$/ { print $2; exit }'
)
[[ "${CMAKE_VERSION}" == "${RELEASE_VERSION}" ]] ||
fail "CMake version ${CMAKE_VERSION:-<missing>} does not match ${RELEASE_VERSION}"
Expand Down
5 changes: 2 additions & 3 deletions scripts/releasing/verify_release_candidate.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,9 +167,8 @@ for required_file in LICENSE NOTICE CMakeLists.txt docs/source/conf.py; do
done

CMAKE_VERSION=$(
sed -n 's/^[[:space:]]*VERSION[[:space:]]\+\([0-9][0-9.]*\).*$/\1/p' \
"${SOURCE_DIR}/CMakeLists.txt" |
head -n 1
awk '$1 == "VERSION" && $2 ~ /^[0-9]+\.[0-9]+\.[0-9]+$/ { print $2; exit }' \
"${SOURCE_DIR}/CMakeLists.txt"
)
[[ "${CMAKE_VERSION}" == "${RELEASE_VERSION}" ]] ||
fail "CMake version ${CMAKE_VERSION:-<missing>} does not match ${RELEASE_VERSION}"
Expand Down