Skip to content

fix: correct formatting and release version parsing#156

Open
zjw1111 wants to merge 2 commits into
apache:mainfrom
zjw1111:codex/fix-pre-commit-cmake-format
Open

fix: correct formatting and release version parsing#156
zjw1111 wants to merge 2 commits into
apache:mainfrom
zjw1111:codex/fix-pre-commit-cmake-format

Conversation

@zjw1111

@zjw1111 zjw1111 commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Purpose

Linked issue: N/A

Fix two validation issues introduced by PR #155:

  • apply the cmake-format result required by the post-merge pre-commit workflow
  • replace the GNU sed-only \+ expressions in both release scripts with portable POSIX awk version parsing for macOS/BSD compatibility

The release-script fix was moved here from PR #157 so both follow-up fixes can be reviewed together.

Failed pre-commit run: https://github.com/apache/paimon-cpp/actions/runs/30010689906

Tests

  • pre-commit run --all-files
  • bash -n scripts/releasing/create_source_release.sh scripts/releasing/verify_release_candidate.sh
  • reproduced the previous empty result with sed --posix
  • parsed 0.2.3 from the working tree and Git content with the new awk expression
  • created a source archive with create_source_release.sh --version 0.2.3 --git-ref HEAD
  • verified the archive with verify_release_candidate.sh --allow-unsigned --skip-rat --skip-build
  • git diff --check upstream/main

API and Format

No API, storage format, or protocol changes.

Documentation

No documentation changes.

Generative AI tooling

Generated-by: Codex (GPT-5)

@zjw1111 zjw1111 changed the title style: apply cmake-format to examples fix: correct formatting and release version parsing Jul 24, 2026

@lxy-9602 lxy-9602 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants