fix: correct formatting and release version parsing#156
Open
zjw1111 wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: N/A
Fix two validation issues introduced by PR #155:
\+expressions in both release scripts with portable POSIX awk version parsing for macOS/BSD compatibilityThe release-script fix was moved here from PR #157 so both follow-up fixes can be reviewed together.
Failed pre-commit run: https://github.com/apache/paimon-cpp/actions/runs/30010689906
Tests
pre-commit run --all-filesbash -n scripts/releasing/create_source_release.sh scripts/releasing/verify_release_candidate.shsed --posix0.2.3from the working tree and Git content with the new awk expressioncreate_source_release.sh --version 0.2.3 --git-ref HEADverify_release_candidate.sh --allow-unsigned --skip-rat --skip-buildgit diff --check upstream/mainAPI and Format
No API, storage format, or protocol changes.
Documentation
No documentation changes.
Generative AI tooling
Generated-by: Codex (GPT-5)