Skip to content

net/devif: harden devif_conn_event() against list mutation #19124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
masc2008 wants to merge 1 commit into
base: master
Choose a base branch
from
+14 −0
Open

net/devif: harden devif_conn_event() against list mutation #19124

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions net/devif/devif_callback.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -455,12 +455,26 @@ uint32_t devif_conn_event(FAR struct net_driver_s *dev, uint32_t flags,

if (list->event != NULL && devif_event_trigger(flags, list->flags))
{
list->free_flags |= DEVIF_CB_DONT_FREE;

/* Yes.. perform the callback. Actions perform by the callback
* may delete the current list entry or add a new list entry to
* beginning of the list (which will be ignored on this pass)
*/

flags = list->event(dev, list->priv, flags);
list->free_flags &= ~DEVIF_CB_DONT_FREE;

/* update the next callback to prevent previously recorded the
* next callback from being deleted
*/

next = list->nxtconn;
if ((list->free_flags & DEVIF_CB_PEND_FREE) != 0)
{
list->free_flags &= ~DEVIF_CB_PEND_FREE;
devif_callback_free(dev, list, NULL, NULL);
}
}

/* Set up for the next time through the loop */
Expand Down
Loading