Skip to content

refactor(headless): extract fixed prompt WAL types - #1261

Merged
Astro-Han merged 1 commit into
apache:mainfrom
me2seeks:refactor/1084-fixed-prompt-wal-types
Jul 29, 2026
Merged

refactor(headless): extract fixed prompt WAL types#1261
Astro-Han merged 1 commit into
apache:mainfrom
me2seeks:refactor/1084-fixed-prompt-wal-types

Conversation

@me2seeks

@me2seeks me2seeks commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Summary

  • extract the fixed-prompt WAL schema constants and event types from fixed-prompt-controller.ts into fixed-prompt-wal-types.ts
  • preserve existing controller imports through explicit compatibility re-exports without exposing the formerly internal UnscoredCellFailureClass
  • move package-local production schema consumers to the new owner and add an extraction contract that locks ownership, compatibility, and one-way dependency direction

The JSONL schema and runtime behavior are unchanged. This is behavior- and visually-neutral.

Refs #1084.

Verification

  • npm run lint — passed
  • npm run build — passed
  • npm run typecheck — passed
  • npm --workspace @maka/headless test — 1,122 passed, 0 failed, 1 skipped
  • npm run test:dist — passed; all workspace tests passed
  • npx biome format packages/headless/src — clean (203 files)
  • npm run format:check — passed after rebasing onto main@bfb9ba83
  • git diff origin/main...HEAD --check — passed
  • git range-diff against the pre-rebase commit — patch equivalent

Visual validation is not applicable: this is a Headless-only, behavior-neutral module extraction.

Review focus

  • the controller keeps the existing WAL exports as an explicit compatibility surface
  • package-local production consumers import the schema leaf directly
  • the new leaf has no Node or controller dependency, and the source contract keeps that direction stable

@Astro-Han Astro-Han left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No code findings in the type extraction. only a rebase is needed before merge.

@me2seeks

Copy link
Copy Markdown
Contributor Author

Thanks for the review. I’ll rebase this onto the current main, resolve the conflicts, and rerun the headless checks. After #1261 is clean, I plan to pick up #1585, which touches the same controller, as a separate follow-up PR.

Move fixed-prompt WAL schema constants and event types into a package-local leaf, then migrate production schema consumers to depend on it directly.

Keep controller imports compatible through explicit re-exports and add a source contract for ownership and dependency direction. The JSONL schema and runtime behavior are unchanged.
@me2seeks
me2seeks force-pushed the refactor/1084-fixed-prompt-wal-types branch from cef35a1 to 198af97 Compare July 29, 2026 03:49
@me2seeks

Copy link
Copy Markdown
Contributor Author

Rebased onto the current main and resolved the conflicts while keeping the current provider-neutral TaskRunner/Pier contracts and the WAL fields added since this PR was opened. Local typecheck, lint, format, and the full Headless suite pass (1429 passed, 4 environment-skipped). GitHub typecheck and test are also green. The E2E job had one unrelated Desktop timeout in session-management.spec.ts after 75 tests passed; I do not have permission to rerun the upstream job. Could someone rerun the failed E2E check? If it reproduces, I’ll investigate it further.

@Astro-Han
Astro-Han merged commit 06d802d into apache:main Jul 29, 2026
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants