refactor(core): split settings into domain owners - #1265
Merged
Astro-Han merged 1 commit intoJul 20, 2026
Conversation
23 tasks
Move bot-chat types, defaults, merging, and readiness normalization into a package-local owner, then migrate package-local consumers to the leaf while keeping the existing settings and root exports compatible. Move web-search credential reconciliation beside its settings model and give the persisted and runtime network contracts distinct canonical names, with deprecated NetworkSettings aliases for compatibility. Add focused behavior tests and a source-boundary contract. Behavior and persisted shapes are unchanged. Part of apache#1084.
me2seeks
force-pushed
the
refactor/1084-core-settings-split
branch
from
July 20, 2026 09:42
4243813 to
1351a73
Compare
Contributor
Author
|
The branches for this PR and #1261 have been rebased onto the latest green
Could a maintainer approve both runs when convenient? Both rebases are patch-equivalent, and local build, lint, format, typecheck, and targeted package tests pass. Thanks! |
Astro-Han
approved these changes
Jul 20, 2026
Astro-Han
left a comment
Contributor
There was a problem hiding this comment.
No concrete findings. I checked the bot-chat and web-search moves against their original implementations, the compatibility exports from the root and settings entry points, and the persisted/runtime network aliases. The extraction preserves the existing shapes and keeps the new leaf modules independent from settings.ts. Typecheck, test, and e2e are green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bot-chat-settings.ts, and move package-local bot consumers to that ownerweb-search.ts, together with their focused testsAppNetworkSettingsfrom runtimeRuntimeNetworkSettings, while keeping both existingNetworkSettingsimports as deprecated compatibility aliasesThe existing readiness, allowlist, and credential-safety comments move with their implementations; only stale function and source-location references were updated. Runtime behavior and persisted settings shapes are unchanged.
Refs #1084.
Verification
npm run build— passednpm run typecheck— passednpm run test:dist— passed; all workspace tests passednpm run lint— passednpm run format:check— passed after rebasing ontomain@bfb9ba83git diff origin/main...HEAD --check— passedgit range-diffagainst the pre-rebase commit — patch equivalentVisual validation is not applicable: this is a behavior-neutral settings module extraction with no UI changes.
Review focus
settings.tsremains the composition and compatibility surface; package-local bot consumers import their real owner directlysettings.ts