Skip to content

Pipe: disable serialize-by-region by default #18140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Caideyipi wants to merge 1 commit into
base: dev/1.3
Choose a base branch
from
+8 −8
Open

Pipe: disable serialize-by-region by default #18140

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ...node/src/test/java/org/apache/iotdb/db/pipe/agent/plugin/PipeDataNodePluginAgentTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,17 +134,17 @@ public void testPipePluginAgent() {
}))
.getClass());
Assert.assertEquals(
IoTDBDataRegionSyncSink.class,
IoTDBDataRegionAsyncSink.class,
agent.dataRegion().reflectSink(new PipeParameters(new HashMap<>())).getClass());
Assert.assertEquals(
IoTDBDataRegionAsyncSink.class,
IoTDBDataRegionSyncSink.class,
agent
.dataRegion()
.reflectSink(
new PipeParameters(
new HashMap<String, String>() {
{
put(PipeSinkConstant.CONNECTOR_SERIALIZE_BY_REGION_KEY, "false");
put(PipeSinkConstant.CONNECTOR_SERIALIZE_BY_REGION_KEY, "true");
}
}))
.getClass());
Expand Down
8 changes: 4 additions & 4 deletions ...est/java/org/apache/iotdb/db/pipe/agent/task/subtask/sink/PipeSinkSubtaskManagerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,20 +33,20 @@
public class PipeSinkSubtaskManagerTest {

@Test
public void testGenerateAttributeSortedStringAddsRegionPrefixAndIgnoresRestartFlag() {
public void testGenerateAttributeSortedStringUsesSerializeByRegionAndIgnoresRestartFlag() {
final Map<String, String> attributes = new HashMap<>();
attributes.put("z", "1");
attributes.put("a", "2");
attributes.put(SystemConstant.RESTART_OR_NEWLY_ADDED_KEY, Boolean.TRUE.toString());

Assert.assertEquals(
"data_region_-1_{a=2, z=1}",
"data_{a=2, z=1}",
PipeSinkSubtaskManager.generateAttributeSortedString(
new PipeParameters(new HashMap<>(attributes)), -1));

attributes.put(PipeSinkConstant.CONNECTOR_SERIALIZE_BY_REGION_KEY, Boolean.FALSE.toString());
attributes.put(PipeSinkConstant.CONNECTOR_SERIALIZE_BY_REGION_KEY, Boolean.TRUE.toString());
Assert.assertEquals(
"data_{a=2, connector.serialize-by-region=false, z=1}",
"data_region_-1_{a=2, connector.serialize-by-region=true, z=1}",
PipeSinkSubtaskManager.generateAttributeSortedString(
new PipeParameters(new HashMap<>(attributes)), -1));
}
Expand Down
2 changes: 1 addition & 1 deletion ...commons/src/main/java/org/apache/iotdb/commons/pipe/config/constant/PipeSinkConstant.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ public class PipeSinkConstant {

public static final String CONNECTOR_SERIALIZE_BY_REGION_KEY = "connector.serialize-by-region";
public static final String SINK_SERIALIZE_BY_REGION_KEY = "sink.serialize-by-region";
public static final boolean CONNECTOR_SERIALIZE_BY_REGION_DEFAULT_VALUE = true;
public static final boolean CONNECTOR_SERIALIZE_BY_REGION_DEFAULT_VALUE = false;

public static boolean isSerializeByRegionEnabled(final PipeParameters parameters) {
return parameters.getBooleanOrDefault(
Expand Down
Loading