Skip to content

Pipe: disable serialize-by-region by default#18140

Open
Caideyipi wants to merge 1 commit into
apache:dev/1.3from
Caideyipi:pipe-serialize-by-region-default-off-dev-1.3
Open

Pipe: disable serialize-by-region by default#18140
Caideyipi wants to merge 1 commit into
apache:dev/1.3from
Caideyipi:pipe-serialize-by-region-default-off-dev-1.3

Conversation

@Caideyipi

Copy link
Copy Markdown
Collaborator

Description

This PR changes the default value of connector.serialize-by-region / sink.serialize-by-region to false on dev/1.3, so the serialize-by-region sink behavior added in #17946 is opt-in by default.

It also updates related unit expectations so the default data-region sink remains the async IoTDB thrift sink, while explicitly enabling serialize-by-region still selects the sync sink and uses region-prefixed subtask attributes.

Tests

  • git diff origin/dev/1.3 --check
  • mvn spotless:apply -pl iotdb-core/node-commons,iotdb-core/datanode -DskipTests
  • mvn -pl iotdb-core/node-commons install -DskipTests -Ddevelocity.off=true
  • mvn -pl iotdb-core/datanode -Dtest=PipeDataNodePluginAgentTest,PipeSinkSubtaskManagerTest test -Ddevelocity.off=true

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants