Skip to content

Remove redundant .keys() in dict membership and iteration #4263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Fokko merged 1 commit into from
Nov 2, 2026
Merged

Remove redundant .keys() in dict membership and iteration #4263

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pyiceberg/catalog/dynamodb.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -704,7 +704,7 @@ def _convert_dynamo_table_item_to_iceberg_table(self, dynamo_table_item: dict[st
DYNAMODB_COL_NAMESPACE,
DYNAMODB_COL_CREATED_AT,
]:
if prop not in table_dict.keys():
if prop not in table_dict:
raise NoSuchPropertyException(f"Iceberg required property {prop} is missing: {dynamo_table_item}")

table_type = table_dict[_add_property_prefix(TABLE_TYPE)]
Expand Down
2 changes: 1 addition & 1 deletion pyiceberg/table/update/snapshot.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1008,7 +1008,7 @@ def merge_manifests(self, manifests: list[ManifestFile]) -> list[ManifestFile]:
groups = self._group_by_spec(manifests)

merged_manifests = []
for spec_id in reversed(groups.keys()):
for spec_id in reversed(groups):
merged_manifests.extend(self._merge_group(first_manifest, spec_id, groups[spec_id]))

return merged_manifests
Expand Down
Loading