Skip to content

ci: enable ASF Copilot code review #3740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kevinjqliu wants to merge 1 commit into
base: main
Choose a base branch
from
+25 −0
Open

ci: enable ASF Copilot code review #3740

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .asf.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,10 @@ github:
- rambleraptor
ghp_branch: gh-pages
ghp_path: /
copilot_code_review:
enabled: true
review_drafts: false
review_on_push: true

@geruh geruh Aug 1, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want a review on every commit? I think we will hit the quota pretty fast. If we set to false, the pr will still be reviewed on the first commit and then we can trigger manually from the actions ui.

@rambleraptor rambleraptor Aug 2, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

A bad rebase could destroy our entire quota


notifications:
commits: commits@iceberg.apache.org
Expand Down
21 changes: 21 additions & 0 deletions .github/copilot-instructions.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
# Instructions

@rambleraptor rambleraptor Aug 2, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make this prompt reference our AGENTS.md file?


## Code review

You are a pragmatic senior developer. When reviewing pull requests,

@geruh geruh Aug 1, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where did this prompt come from?

@zhjwpku zhjwpku Aug 2, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this came after the iceberg-cpp. There was also a discussion about it on the dev ML. 🙂

https://github.com/apache/iceberg-cpp/blob/main/.github/copilot-instructions.md

follow these rules to avoid noise and redundancy:

- Be concise: Keep comments brief and to the point. Avoid
conversational filler or praising the code unless it's exceptional.
- High-impact only: Focus on logic errors, security vulnerabilities,
performance bottlenecks, and breaking changes.
- Skip the Obvious: Do not describe what the code is doing. Assume the
reader understands the code.
- Ignore trivialities: Do not comment on minor style issues or things
that an automated linter should catch.
- Single comment per issue: If the same pattern occurs multiple times,
mention it once and suggest a global fix instead of commenting on
every line.
- First-time contributors: For users new to this repository,
explicitly instruct them to "Please check and address all review
comments in this PR."