ci: enable ASF Copilot code review - #3740
Open
kevinjqliu wants to merge 1 commit into
Open
Conversation
geruh
reviewed
Aug 1, 2026
|
|
||
| ## Code review | ||
|
|
||
| You are a pragmatic senior developer. When reviewing pull requests, |
Contributor
There was a problem hiding this comment.
I think this came after the iceberg-cpp. There was also a discussion about it on the dev ML. 🙂
https://github.com/apache/iceberg-cpp/blob/main/.github/copilot-instructions.md
| copilot_code_review: | ||
| enabled: true | ||
| review_drafts: false | ||
| review_on_push: true |
Member
There was a problem hiding this comment.
Do we want a review on every commit? I think we will hit the quota pretty fast. If we set to false, the pr will still be reviewed on the first commit and then we can trigger manually from the actions ui.
Collaborator
There was a problem hiding this comment.
+1
A bad rebase could destroy our entire quota
rambleraptor
reviewed
Aug 2, 2026
| @@ -0,0 +1,21 @@ | |||
| # Instructions | |||
Collaborator
There was a problem hiding this comment.
Can we make this prompt reference our AGENTS.md file?
zhjwpku
approved these changes
Aug 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Inspired by apache/iceberg-cpp#833
This will enable github to automatically request copilot review on PRs where the author has access to copilot
Are these changes tested?
Are there any user-facing changes?