Repository navigation
Conversation
Validate required shard scan bounds while retaining explicit empty bounds and paging behavior. Use a community-compatible Topling profile and validate its plugins before runtime publication. Include preparation tools and document standalone images, storage paths and Gremlin bindings. Cover scan HTTP behavior and runtime preparation failures with regressions.
This was referenced Nov 2, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3447 +/- ##
===========================================
Coverage 58.42% 58.42%
+ Complexity 6903 3078 -3825
===========================================
Files 779 779
Lines 69391 69395 +4
Branches 9567 9571 +4
===========================================
+ Hits 40539 40546 +7
+ Misses 25179 25174 -5
- Partials 3673 3675 +2
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
bitflicker64
approved these changes
Nov 2, 2026
bitflicker64
left a comment
bitflicker64
left a comment
Contributor
There was a problem hiding this comment.
Blocking: no. Score: 9/10. Summary: Missing start or end on vertices/scan and edges/scan returns 400 while empty bounds and paging keep working, and the shipped toplingdb.yaml imports and opens with a community Topling JNI that rejects the previous CSPP profile.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before → After
Before: standalone shard scans with an omitted bound can return HTTP 500, and a native profile unsupported by the selected community JNI can pass preparation but fail initialization.
After: validate missing scan bounds as HTTP 400 while preserving explicit empty bounds and paging contracts; validate community-compatible native profiles before runtime publication, include unzip in runtime images, and document standalone storage/configuration contracts.
Source: hugegraph#363
Paired documentation source: apache/hugegraph-doc#559
Validation boundary
The source PR records local Java/API/preparation and real standalone RocksDB/Topling checks; these are author-reported, not independently reproduced here. Published images, live HStore/Helm acceptance and Topling variant round trips remain unverified. Four existing standalone-management assertions failed in the broader suite and are not counted as passing. Coordinate the implementation and documentation merges.
Visual overview
Before → After: missing shard bounds return HTTP 400 while explicit empty bounds remain valid; Topling preparation adds actual-profile native import after the isolated EasyMigrate probe, before installing local runtime files. Profile import does not open production databases or convert existing SSTs, and it does not establish deployment or data-compatibility acceptance.
Reviewed: 2026-11-02. Source: 🔗 hugegraph/hugegraph #363 reviewed version.