Repository navigation
Conversation
bitflicker64
left a comment
There was a problem hiding this comment.
Blocking: yes. Summary: The standalone deployment, Gremlin binding and shard-scan text matches apache/hugegraph master 8e327b8 or is scoped to the fixes in apache/hugegraph#3447, but the Topling default-profile paragraph describes a profile that no build ships until apache/hugegraph#3447 merges.
| The shipped native profile disables its HTTP server and keeps `memtable_as_log_index=false`, which the Java write path requires. | ||
| Tune that profile for the host; it is separate from the business provider and data-path configuration. | ||
|
|
||
| Updated distributions use community-compatible SkipList memtables and BlockBasedTable files by default. |
There was a problem hiding this comment.
Important: master's Server conf/toplingdb.yaml still selects the cspp memtable and a DispatcherTable over CSPPMemTabTable, and the SkipList/BlockBasedTable profile exists only in open apache/hugegraph#3447, so a user with a community Topling JNI who trusts this paragraph on any current build fails at Server initialization. Merge this after apache/hugegraph#3447, or name the Server version that ships that profile here and in the cn mirror.
- Distinguish standalone RocksDB artifacts from HStore and Helm single-node presets. - Document required scan bounds and explicit pagination without changing the unpaged contract. - Correct standalone Gremlin aliases and GraphSpace-scoped traversal sources. - Clarify ToplingDB community SkipList/BlockBasedTable profile version boundary (Server 1.8.0+ / #3447 vs legacy cspp memtable).
ca75f7e to
9348fc4
Compare
|
Thanks @bitflicker64 for the careful review! This PR has been rebased onto current
|
Limit empty shard bounds to supported backends and describe the all-backend required-bound change. Qualify local-backend image reuse by the wait and data-directory fixes. Document Topling configuration precedence, absolute path handling and legacy CSPP upgrade requirements.
bitflicker64
left a comment
There was a problem hiding this comment.
Blocking: yes. Summary: The standalone deployment, Gremlin binding, shard-scan and HStore-reuse text matches apache/hugegraph master 8e327b8 and 1.7.0, or is scoped to fixes in open apache/hugegraph#3447. The Topling version note added since the last review misstates what master and 1.7.0 ship.
| The shipped native profile disables its HTTP server and keeps `memtable_as_log_index=false`, which the Java write path requires. | ||
| Tune that profile for the host; it is separate from the business provider and data-path configuration. | ||
|
|
||
| Starting with Server 1.8.0+ (master), distributions ship a community-native profile in `conf/toplingdb.yaml` |
There was a problem hiding this comment.
Important: master's conf/toplingdb.yaml still selects the cspp memtable and DispatcherTable, and the 1.7.0 release ships no Topling profile or prepare-topling.sh, so a community-JNI user on master who trusts this paragraph hits the initialization failure it warns about. Scope the SkipList profile to builds containing the compatibility-profile fix, as line 128 does, and drop the 1.7.0 sentence here and in the cn mirror.
Before → After
Before: Standalone setup contracts, shard-bound requirements, and community-native Topling profile preparation were not documented consistently across both languages.
After:
origin/master(post-docs: unify client navi struct and streamline GQL docs (EN/CN) #557), cleanly incorporating PR docs: unify client navi struct and streamline GQL docs (EN/CN) #557's OINK components (Steps, Tabs, Cards, Alerts) and traverser batch APIs alongside PR docs: clarify standalone deployment contracts #559's standalone deployment contracts.rocksdb-data), configuration write permissions, and Java 17/auth initialization.__g_DEFAULT-hugegraphand graph bindingDEFAULT-hugegraph.startandendbounds (explicit empty values for open bounds, HTTP 400 when missing) and explicitpagepagination semantics for vertex and edge scans.conf/toplingdb.yamlapplies to Server 1.8.0+ (apache/hugegraph#3447/ master), whereas existing/prior builds (such as 1.7.0) ship withcsppmemtable andDispatcherTable.Source: hugegraph#60
Paired implementation source: apache/hugegraph#3447
Validation boundary & results
./scripts/hugo.sh buildrenders all 668 pages (EN: 335, CN: 333) with 0 errors.bash dist/validate-links.shpasses with 0 broken links.python3 -m unittest discover -s scripts/passes all 290 tests (1 skipped).git diff --checkclean.Visual overview
Before → After: missing shard bounds return HTTP 400 while explicit empty bounds remain valid; Topling preparation adds actual-profile native import after the isolated EasyMigrate probe, before installing local runtime files. Profile import does not open production databases or convert existing SSTs, and it does not establish deployment or data-compatibility acceptance.