Skip to content

test: skip completed_groups_release_first_value_bitmap under force_hash_collisions #27034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
2010YOUY01 merged 1 commit into from
Nov 3, 2026
Merged

test: skip completed_groups_release_first_value_bitmap under force_hash_collisions #27034

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions datafusion/physical-plan/src/aggregates/clustered_partial_stream.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -424,9 +424,9 @@ mod tests {
use crate::aggregates::GroupClusteringMode;
use crate::aggregates::PhysicalGroupBy;
use crate::aggregates::clustered_test_util::{
aggregate_expr_over_sorted_input, aggregate_over_sorted_input,
assert_completed_groups_emitted_under_limit, assert_output_unchanged_under_limit,
collect_under_limit, distinct_key_batches, full_batches, sum_over_sorted_input,
aggregate_over_sorted_input, assert_completed_groups_emitted_under_limit,
assert_output_unchanged_under_limit, collect_under_limit, distinct_key_batches,
full_batches, sum_over_sorted_input,
};
use crate::test::TestMemoryExec;
use arrow::array::{ArrayRef, Float64Array, Int64Array, ListArray};
Expand All @@ -438,7 +438,6 @@ mod tests {
use datafusion_execution::runtime_env::RuntimeEnvBuilder;
use datafusion_functions_aggregate::any_value::any_value_udaf;
use datafusion_functions_aggregate::approx_distinct::approx_distinct_udaf;
use datafusion_functions_aggregate::first_last::first_value_udaf;
use datafusion_functions_aggregate::sum::sum_udaf;
use datafusion_physical_expr::PhysicalSortExpr;
use datafusion_physical_expr::aggregate::AggregateExprBuilder;
Expand Down Expand Up @@ -610,8 +609,15 @@ mod tests {
/// `FIRST_VALUE(v ORDER BY v)` accumulator. It keeps a bitmap of the
/// groups each batch updated, which grows to one bit per group (16 KB for
/// 131072 groups), so it must release that bitmap too.
///
/// Skipped under `force_hash_collisions`, where the 131,072 colliding group
/// keys make the aggregate quadratic and the test take many minutes.
#[cfg(not(feature = "force_hash_collisions"))]
#[tokio::test]
async fn completed_groups_release_first_value_bitmap() -> Result<()> {
use crate::aggregates::clustered_test_util::aggregate_expr_over_sorted_input;
use datafusion_functions_aggregate::first_last::first_value_udaf;

let plan = aggregate_expr_over_sorted_input(
AggregateMode::Partial,
&["k"],
Expand Down
Loading