Repository navigation
test: skip completed_groups_release_first_value_bitmap under force_hash_collisions - #27034
Merged
Merged
Conversation
…sh_collisions The test aggregates 131,072 distinct keys in one batch. With colliding hashes, the aggregate is quadratic and the test takes about 10 minutes in the hash-collision CI job. Closes apache#27033.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
completed_groups_release_first_value_bitmap(added in #26782) takes about 10 minutes in thecargo test hash collisions (amd64)merge-queue job. It aggregates 131,072 distinct keys in one batch. Underforce_hash_collisions, every key has the hash 0, so the aggregate is quadratic. The test checks thatFIRST_VALUE(v ORDER BY v)releases its per-batch bitmap, which does not depend on hashing.The long job gives spot runner shutdowns more time to hit it. Evidence from merge-queue runs:
BoundedWindowAggExecoutput intobatch_sizebatches #26974 (job), docs: Clarify Known Users criteria and clean up active project list #26926 (job).What changes are included in this PR?
Skip the test under
force_hash_collisions, as #26594 did for another test. The imports that only this test uses move into its body, so they are not unused under the feature.What is the testing strategy for this PR?
Test config change only. The regular
cargo testjob still runs the test. Locally (--profile ci), the test takes 0.92s by default and 309s withforce_hash_collisions. With the feature, it is now skipped, and Clippy passes with and without the feature.Are there any user-facing changes?
No.