Repository navigation
PostgreSQL: Support column OPTIONS in CREATE FOREIGN TABLE - #2755
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2755 +/- ##
=======================================
Coverage 82.87% 82.87%
=======================================
Files 42 42
Lines 35968 35985 +17
Branches 35968 35985 +17
=======================================
+ Hits 29807 29822 +15
- Misses 2654 2658 +4
+ Partials 3507 3505 -2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
LucaCappelletti94
force-pushed
the
upstream/foreign-table-column-options
branch
5 times, most recently
from
October 30, 2026 08:30
a747dd5 to
035b5a6
Compare
LucaCappelletti94
force-pushed
the
upstream/foreign-table-column-options
branch
from
October 30, 2026 10:58
035b5a6 to
b23a507
Compare
| @@ -0,0 +1 @@ | |||
| CREATE FOREIGN TABLE ft (id INT OPTIONS (column_name 'remote_id') NOT NULL) SERVER s No newline at end of file | |||
Contributor
There was a problem hiding this comment.
are these files supposed to have an ending new line? I see a mix of both.
Contributor
Author
There was a problem hiding this comment.
Both is fine, they are read as plain text basically.
LucaCappelletti94
force-pushed
the
upstream/foreign-table-column-options
branch
8 times, most recently
from
October 31, 2026 17:23
28f9473 to
0716196
Compare
Contributor
Author
|
Thanks @sabir-akhadov-localstack for your review, I will be merging this now. cc @alamb |
LucaCappelletti94
enabled auto-merge
October 31, 2026 17:45
LucaCappelletti94
force-pushed
the
upstream/foreign-table-column-options
branch
from
October 31, 2026 18:09
0716196 to
8567574
Compare
Contributor
|
We are cooking for real now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CREATE FOREIGN TABLE ft (id INT OPTIONS (column_name 'remote_id')) SERVER sfailed atOPTIONS. The column option now parses asColumnOption::GenericOptionsbehind a newDialect::supports_column_generic_options, enabled for PostgreSQL. The Generic dialect keeps BigQuery'sOPTIONS(key = value)form, which uses the same keyword. PostgreSQL's grammar takes the clause on any column definition and refuses it on a table that is not foreign only at execution, soCREATE TABLEaccepts it too.https://www.postgresql.org/docs/current/sql-createforeigntable.html