Skip to content

CI: Make the coverage check advisory - #2792

Merged
LucaCappelletti94 merged 1 commit into
mainfrom
upstream/coverage-advisory
Nov 1, 2026
Merged

LucaCappelletti94 merged 1 commit into
mainfrom
upstream/coverage-advisory

Conversation

@LucaCappelletti94

Copy link
Copy Markdown
Contributor

The coverage check is a required status check on main. For example, #2755 is approved and green on every other check, but four lines of a Spanned match arm in src/ast/spans.rs have no test, and I have no intention to add because that is code that will likely need a refactoring and its current implementations are all of the "needs improvement" kind.

This removes coverage from the required checks in .asf.yaml. @alamb you were right and I was being a bit too hopeful, lets keep this as just a mark of shame for now.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.87%. Comparing base (7812d86) to head (64c533a).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2792   +/-   ##
=======================================
  Coverage   82.87%   82.87%           
=======================================
  Files          42       42           
  Lines       35968    35968           
  Branches    35968    35968           
=======================================
  Hits        29807    29807           
  Misses       2654     2654           
  Partials     3507     3507           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@LucaCappelletti94

Copy link
Copy Markdown
Contributor Author

cc @alamb merging this one now, as I am just rolling back the daft decision I had argued for and switching back to your variant.

@LucaCappelletti94
LucaCappelletti94 added this pull request to the merge queue Nov 1, 2026
Merged via the queue into main with commit 26c060f Nov 1, 2026
10 checks passed
@alamb

alamb commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

100% - thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants