Skip to content

chore: enable ansi by default for Spark 4 tests #4368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
comphead wants to merge 3 commits into from
+2 −1
Closed

chore: enable ansi by default for Spark 4 tests #4368

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b6dfb4d
chore: enable ansi by default for Spark 4 tests
comphead May 19, 2026
7fa6a47
chore: enable ansi by default for Spark 4 tests
comphead May 19, 2026
257a045
chore: enable ansi by default for Spark 4 tests
comphead May 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion spark/src/test/scala/org/apache/spark/sql/CometTestBase.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ import org.apache.spark.sql.test._
import org.apache.spark.sql.types.{DecimalType, StructType}

import org.apache.comet._
import org.apache.comet.CometSparkSessionExtensions.isSpark40Plus
import org.apache.comet.shims.ShimCometSparkSessionExtensions

/**
Expand All @@ -72,7 +73,7 @@ abstract class CometTestBase
conf.set("spark.hadoop.fs.file.impl", classOf[DebugFilesystem].getName)
conf.set("spark.ui.enabled", "false")
conf.set(SQLConf.SHUFFLE_PARTITIONS, 10) // reduce parallelism in tests
conf.set(SQLConf.ANSI_ENABLED.key, "false")
conf.set(SQLConf.ANSI_ENABLED.key, isSpark40Plus.toString)
conf.set(SHUFFLE_MANAGER, shuffleManager)
conf.set(MEMORY_OFFHEAP_ENABLED.key, "true")
conf.set(MEMORY_OFFHEAP_SIZE.key, "2g")
Expand Down
Loading