chore: enable ansi by default for Spark 4 tests#4368
Closed
comphead wants to merge 3 commits into
Closed
Conversation
comphead
commented
May 19, 2026
| conf.set("spark.ui.enabled", "false") | ||
| conf.set(SQLConf.SHUFFLE_PARTITIONS, 10) // reduce parallelism in tests | ||
| conf.set(SQLConf.ANSI_ENABLED.key, "false") | ||
| val sparkMajorVersion = |
Contributor
Author
There was a problem hiding this comment.
its to follow defaults, however in future we need to include ansi to the test as ConfigMatrix
UPD: for some case ConfigMatrix won't work and current approach is to have separate files
| conf.set("spark.ui.enabled", "false") | ||
| conf.set(SQLConf.SHUFFLE_PARTITIONS, 10) // reduce parallelism in tests | ||
| conf.set(SQLConf.ANSI_ENABLED.key, "false") | ||
| val sparkMajorVersion = |
Contributor
There was a problem hiding this comment.
Isn't there a isSpark40Plus boolean already available?
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
CometTestBasewas unconditionally pinning ANSI tofalse, which meant the Spark 4.0 / 4.1 / 4.2 test profiles never actually exercised the ANSI behavior that real Spark 4 users get out of the box.Tests that pass under Comet today may regress in production because we never run them with the same defaults.
What changes are included in this PR?
How are these changes tested?