Progress dialogs should be not cancellable outside the window#28
Progress dialogs should be not cancellable outside the window#28optikalefx wants to merge 1 commit intoapache:masterfrom
Conversation
|
What are progress dialogs ?? |
|
I'm pretty sure that the pull request title doesn't match the description/implementation. |
|
Sorry about the whitespace. Automatic sublime setting. A progress dialog ( |
|
The current implementation allows the progress 1-100 dialog box to be cancelled by clicking outside the dialog window. This is unexpected behavior for the user. |
|
The issue as I meant to imply it is that only Android supports this functionality, ultimately it should be moved/removed, or implemented for more platforms. |
|
iOS is modal by default already. So it already performs the expected behavior. I don't know about the other platforms. At least on Android this is a necessary change, and on iOS we didn't have to do anything. |
|
Looks OK |
|
but could be considered a breaking change. I think we should increment the major version number before merging, will confirm in dev@cordova.apache.org before merging. |
brody4hire
left a comment
There was a problem hiding this comment.
Whitespace cleanup should not be part of this change. I just raised PR #109 to cleanup the whitespace.
This change makes progress dialogs modal. In a sense that they can't be cancelled from an outside touch. This is expected behavior for a progress bar. Too many user errors by mis-tapping outside the progress and then having no clue what happened.