[MAJOR] GH-28 Progress dialogs should not be cancellable outside the window#110
Open
brody4hire wants to merge 1 commit intoapache:masterfrom
Open
[MAJOR] GH-28 Progress dialogs should not be cancellable outside the window#110brody4hire wants to merge 1 commit intoapache:masterfrom
brody4hire wants to merge 1 commit intoapache:masterfrom
Conversation
Member
|
Please update the PR to describe what the codee change actually does, or what the situation before was. |
|
Pretty sure the change results in the dialogs not being cancellable by touching outside the dialog. The problem, as I understand it, is that you can tap anywhere on the screen and thus cancel the dialog, which is almost always unintended for a progress indicator. This change fixes that. |
Member
|
So the PR title is still wrong, correct @oliversalzburg? |
|
@janpio It is unless my interpretation of the change is wrong. |
brody4hire
changed the title
Author
|
I just corrected the title, thanks @oliversalzburg. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposal to cherry-pick the fix proposed in PR #28 without the whitespace fixes that are now part of PR #109. The change in behavior makes sense to me. I think this change should go into a new major release.
Resolves #28