Skip to content

NumberConverter.toNumber(Class, Number): Preserve float and double magnitude when converting to BigInteger #438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
garydgregory merged 1 commit into from
Sep 1, 2026
+13 −0
Merged

NumberConverter.toNumber(Class, Number): Preserve float and double magnitude when converting to BigInteger #438

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/main/java/org/apache/commons/beanutils2/converters/NumberConverter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -493,6 +493,9 @@ private <T> T toNumber(final Class<?> sourceType, final Class<T> targetType, fin
if (value instanceof BigDecimal) {
return targetType.cast(((BigDecimal) value).toBigInteger());
}
if (value instanceof Float || value instanceof Double) {
return targetType.cast(new BigDecimal(value.toString()).toBigInteger());
}
return targetType.cast(BigInteger.valueOf(value.longValue()));
}

Expand Down
10 changes: 10 additions & 0 deletions src/test/java/org/apache/commons/beanutils2/converters/BigIntegerConverterTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@

import static org.junit.jupiter.api.Assertions.assertEquals;

import java.math.BigDecimal;
import java.math.BigInteger;

import org.apache.commons.beanutils2.Converter;
Expand Down Expand Up @@ -62,6 +63,15 @@ public void tearDown() throws Exception {
converter = null;
}

@Test
void testLargeFloatingPointMagnitude() {
// A Float or Double beyond long range must keep its magnitude instead of saturating to Long.MAX_VALUE.
final Double bigDouble = Double.valueOf(1.0e30);
assertEquals(new BigDecimal(bigDouble.toString()).toBigInteger(), converter.convert(BigInteger.class, bigDouble));
final Float bigFloat = Float.valueOf(1.0e20f);
assertEquals(new BigDecimal(bigFloat.toString()).toBigInteger(), converter.convert(BigInteger.class, bigFloat));
}

@Test
void testSimpleConversion() throws Exception {
final String[] message = { "from String", "from String", "from String", "from String", "from String", "from String", "from String", "from Byte",
Expand Down
Loading