NumberConverter.toNumber(Class, Number): Preserve float and double magnitude when converting to BigInteger - #438
Merged
garydgregory merged 1 commit intoSep 1, 2026
Conversation
Member
|
Thank you @rootvector2 , merged 🚀 |
garydgregory
added a commit
that referenced
this pull request
Sep 1, 2026
magnitude when converting to BigInteger (#438).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NumberConverter.toNumber(Class, Number)converts aFloatorDoublesource toBigIntegerthroughBigInteger.valueOf(value.longValue()), so a floating-point magnitude pastlongrange silently saturates instead of keeping its value:converter.convert(BigInteger.class, 1e30d)returns9223372036854775807and1e20freturns the same, not the real magnitude.the sibling
BigDecimalbranch just above already formatsFloat/Doublewithnew BigDecimal(value.toString())to avoid exactly this, and #401 / #408 established thatBigIntegerandBigDecimalconversions must preserve magnitude. this routes floating-point sources throughnew BigDecimal(value.toString()).toBigInteger(); integer sources keep the exactlongValue()path and in-range values are unchanged. found while auditing thetoNumbernarrowing family after #404, which only added theLongandFloatrange checks and never touched theBigIntegerbranch.BigIntegerConverterTest.testLargeFloatingPointMagnitudefails before the change (9223372036854775807) and passes after.mvn; that'smvnon the command line by itself.