Skip to content

Add --add-opens test JVM args for HCatalog and Dataflow worker tests #39351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aIbrahiim wants to merge 2 commits into
base: master
Choose a base branch
from
+13 −2
Open

Add --add-opens test JVM args for HCatalog and Dataflow worker tests #39351

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cc08f3c
Add --add-opens test JVM args for HCatalog and Dataflow worker tests
aIbrahiim Jul 16, 2026
d9ecd8a
add more --add-opens for Dataflow
aIbrahiim Jul 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/trigger_files/beam_PostCommit_Java_Hadoop_Versions.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{
"comment": "Modify this file in a trivial way to cause this test suite to run",
"modification": 4
}
"modification": 5
}
7 changes: 7 additions & 0 deletions runners/google-cloud-dataflow-java/worker/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,6 +154,13 @@ applyJavaNature(
/******************************************************************************/
// Configure the worker root project

tasks.withType(Test).configureEach {
jvmArgs '--add-opens=java.base/java.lang=ALL-UNNAMED',
'--add-opens=java.base/java.util=ALL-UNNAMED',
'--add-opens=java.base/java.util.concurrent=ALL-UNNAMED',
'--add-opens=java.base/java.util.concurrent.atomic=ALL-UNNAMED'
}
Comment on lines +157 to +162

@gemini-code-assist gemini-code-assist Bot Jul 16, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Adding --add-opens directly to jvmArgs will cause test execution to fail on Java 8 environments because Java 8 does not recognize this JVM option. To maintain compatibility with Java 8, wrap the JVM argument configuration in a check for Java 9 or higher.

tasks.withType(Test).configureEach {
  if (JavaVersion.current().isJava9Compatible()) {
    jvmArgs '--add-opens=java.base/java.lang=ALL-UNNAMED'
  }
}


configurations {
sourceFile

Expand Down
4 changes: 4 additions & 0 deletions sdks/java/io/hcatalog/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,10 @@ hadoopVersions.each {kv -> configurations.create("hadoopVersion$kv.key")}

def hive_version = "4.0.1"

tasks.withType(Test).configureEach {
jvmArgs '--add-opens=java.base/java.net=ALL-UNNAMED'
}
Comment on lines +43 to +45

@gemini-code-assist gemini-code-assist Bot Jul 16, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Adding --add-opens directly to jvmArgs will cause test execution to fail on Java 8 environments because Java 8 does not recognize this JVM option. To maintain compatibility with Java 8, wrap the JVM argument configuration in a check for Java 9 or higher. This also corrects the indentation to 2 spaces.

tasks.withType(Test).configureEach {
  if (JavaVersion.current().isJava9Compatible()) {
    jvmArgs '--add-opens=java.base/java.net=ALL-UNNAMED'
  }
}


dependencies {
implementation library.java.vendored_guava_32_1_2_jre
implementation project(path: ":sdks:java:core", configuration: "shadow")
Expand Down
Loading