Skip to content

Add --add-opens test JVM args for HCatalog and Dataflow worker tests#39351

Open
aIbrahiim wants to merge 2 commits into
apache:masterfrom
aIbrahiim:fix-add-opens-java21-tests
Open

Add --add-opens test JVM args for HCatalog and Dataflow worker tests#39351
aIbrahiim wants to merge 2 commits into
apache:masterfrom
aIbrahiim:fix-add-opens-java21-tests

Conversation

@aIbrahiim

@aIbrahiim aIbrahiim commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Fixes: #38286, #33252
Successful runs:


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses compatibility issues encountered during testing by configuring specific JVM flags for the Dataflow worker and HCatalog modules. By adding the necessary --add-opens arguments, the build environment is now properly prepared to handle access requirements for internal Java packages during test execution.

Highlights

  • JVM Configuration: Added --add-opens JVM arguments to the Dataflow worker and HCatalog test suites to resolve compatibility issues with newer Java versions.
  • Test Infrastructure: Updated the Hadoop version trigger file to ensure the relevant test suite is executed.
New Features

🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request configures JVM arguments for test tasks in the Google Cloud Dataflow worker and HCatalog SDK Gradle builds, and includes a trivial change to trigger post-commit tests. The review feedback correctly points out that directly adding --add-opens options will break compatibility with Java 8 environments, and suggests wrapping these configurations in a Java 9 compatibility check.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment on lines +157 to +159
tasks.withType(Test).configureEach {
jvmArgs '--add-opens=java.base/java.lang=ALL-UNNAMED'
}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Adding --add-opens directly to jvmArgs will cause test execution to fail on Java 8 environments because Java 8 does not recognize this JVM option. To maintain compatibility with Java 8, wrap the JVM argument configuration in a check for Java 9 or higher.

tasks.withType(Test).configureEach {
  if (JavaVersion.current().isJava9Compatible()) {
    jvmArgs '--add-opens=java.base/java.lang=ALL-UNNAMED'
  }
}

Comment on lines +43 to +45
tasks.withType(Test).configureEach {
jvmArgs '--add-opens=java.base/java.net=ALL-UNNAMED'
}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Adding --add-opens directly to jvmArgs will cause test execution to fail on Java 8 environments because Java 8 does not recognize this JVM option. To maintain compatibility with Java 8, wrap the JVM argument configuration in a check for Java 9 or higher. This also corrects the indentation to 2 spaces.

tasks.withType(Test).configureEach {
  if (JavaVersion.current().isJava9Compatible()) {
    jvmArgs '--add-opens=java.base/java.net=ALL-UNNAMED'
  }
}

@github-actions

Copy link
Copy Markdown
Contributor

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@Abacn

Abacn commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Most of the error looks like below

java.lang.reflect.InaccessibleObjectException: Unable to make field private final int java.lang.Integer.value accessible: module java.base does not "opens java.lang" to unnamed module @7905a0b8
	...
	at java.base/java.lang.reflect.Field.checkCanSetAccessible(Field.java:183)
	at java.base/java.lang.reflect.Field.setAccessible(Field.java:177)
	at org.apache.beam.runners.dataflow.worker.WindmillStateTestUtils.assertNoReference(WindmillStateTestUtils.java:70)

We should fix assertNoReference to handle java.lang primitives. Working on it now.

Update: had master...Abacn:beam:assert-no-ref however it seems there are too many Types need to handle. Open modules should be fine. Please just add a comment saying it's for WindmillStateTestUtils.assertNoReference need to iterate over all references in the cache

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The PreCommit Java Dataflow Non-portable Worker job is flaky

2 participants