Add --add-opens test JVM args for HCatalog and Dataflow worker tests#39351
Add --add-opens test JVM args for HCatalog and Dataflow worker tests#39351aIbrahiim wants to merge 2 commits into
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses compatibility issues encountered during testing by configuring specific JVM flags for the Dataflow worker and HCatalog modules. By adding the necessary --add-opens arguments, the build environment is now properly prepared to handle access requirements for internal Java packages during test execution. Highlights
New Features🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request configures JVM arguments for test tasks in the Google Cloud Dataflow worker and HCatalog SDK Gradle builds, and includes a trivial change to trigger post-commit tests. The review feedback correctly points out that directly adding --add-opens options will break compatibility with Java 8 environments, and suggests wrapping these configurations in a Java 9 compatibility check.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| tasks.withType(Test).configureEach { | ||
| jvmArgs '--add-opens=java.base/java.lang=ALL-UNNAMED' | ||
| } |
There was a problem hiding this comment.
Adding --add-opens directly to jvmArgs will cause test execution to fail on Java 8 environments because Java 8 does not recognize this JVM option. To maintain compatibility with Java 8, wrap the JVM argument configuration in a check for Java 9 or higher.
tasks.withType(Test).configureEach {
if (JavaVersion.current().isJava9Compatible()) {
jvmArgs '--add-opens=java.base/java.lang=ALL-UNNAMED'
}
}
| tasks.withType(Test).configureEach { | ||
| jvmArgs '--add-opens=java.base/java.net=ALL-UNNAMED' | ||
| } |
There was a problem hiding this comment.
Adding --add-opens directly to jvmArgs will cause test execution to fail on Java 8 environments because Java 8 does not recognize this JVM option. To maintain compatibility with Java 8, wrap the JVM argument configuration in a check for Java 9 or higher. This also corrects the indentation to 2 spaces.
tasks.withType(Test).configureEach {
if (JavaVersion.current().isJava9Compatible()) {
jvmArgs '--add-opens=java.base/java.net=ALL-UNNAMED'
}
}
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
|
Most of the error looks like below We should fix assertNoReference to handle java.lang primitives. Working on it now. Update: had master...Abacn:beam:assert-no-ref however it seems there are too many Types need to handle. Open modules should be fine. Please just add a comment saying it's for WindmillStateTestUtils.assertNoReference need to iterate over all references in the cache |
Fixes: #38286, #33252
Successful runs:
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.