Skip to content

GH-49465: [CI][C++] Fix Abseil hang in arrow-flight-test on ODBC Windows #50085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tadeja wants to merge 6 commits into
base: main
Choose a base branch
from
+34 −1
Open

GH-49465: [CI][C++] Fix Abseil hang in arrow-flight-test on ODBC Windows #50085

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
8e60a59
debug process exit hang on MSVC
tadeja May 29, 2026
eeb2299
debug hung process during ctest
tadeja May 29, 2026
76abb0a
test GPR_DISABLE_ABSEIL_SYNC for flight exit hang
tadeja May 30, 2026
f2587ae
fix ARROW_CXXFLAGS slash for bash
tadeja May 31, 2026
7aecc6e
confirm fix by ctest repeats
tadeja Jun 2, 2026
c20daf7
remove diagnostics and keep fix
tadeja Jun 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion .github/workflows/cpp_extra.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -554,10 +554,19 @@ jobs:
ARROW_FLIGHT_SQL_ODBC: ON
ARROW_FLIGHT_SQL_ODBC_INSTALLER: ON
ARROW_HOME: /usr
# GH-49465: work around the gRPC/Abseil exit hang on Windows
# https://github.com/grpc/grpc/issues/39321
# https://github.com/abseil/abseil-cpp/issues/1877
# Build Arrow with GPR_DISABLE_ABSEIL_SYNC so grpcpp's Mutex ABI
# matches the gRPC rebuilt by the overlay triplet. Remove once fixed upstream.
ARROW_CXXFLAGS: -DGPR_DISABLE_ABSEIL_SYNC
CMAKE_GENERATOR: Ninja
CMAKE_INSTALL_PREFIX: /usr
VCPKG_BINARY_SOURCES: 'clear;nugettimeout,600;nuget,GitHub,readwrite'
VCPKG_DEFAULT_TRIPLET: x64-windows
# GH-49465: custom triplet that rebuilds gRPC with GPR_DISABLE_ABSEIL_SYNC
# (native sync instead of absl::Mutex). See ci/vcpkg/overlay-triplets-no-absl-sync.
VCPKG_DEFAULT_TRIPLET: x64-windows-no-absl-sync
VCPKG_OVERLAY_TRIPLETS: ${{ github.workspace }}/ci/vcpkg/overlay-triplets-no-absl-sync
steps:
- name: Disable Crash Dialogs
run: |
Expand Down
24 changes: 24 additions & 0 deletions ci/vcpkg/overlay-triplets-no-absl-sync/x64-windows-no-absl-sync.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
# Licensed to the Apache Software Foundation (ASF) under one
# or more contributor license agreements. See the NOTICE file
# distributed with this work for additional information
# regarding copyright ownership. The ASF licenses this file
# to you under the Apache License, Version 2.0 (the
# "License"); you may not use this file except in compliance
# with the License. You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing,
# software distributed under the License is distributed on an
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.

# GH-49465: rebuild gRPC with native sync instead of absl::Mutex to avoid the
# Windows exit hang. See the ODBC Windows job in cpp_extra.yml
set(VCPKG_TARGET_ARCHITECTURE x64)
set(VCPKG_CRT_LINKAGE dynamic)
set(VCPKG_LIBRARY_LINKAGE dynamic)
set(VCPKG_C_FLAGS "/DGPR_DISABLE_ABSEIL_SYNC")
set(VCPKG_CXX_FLAGS "/DGPR_DISABLE_ABSEIL_SYNC")
Loading