GH-49465: [CI][C++] Fix Abseil hang in arrow-flight-test on ODBC Windows#50085
Open
tadeja wants to merge 6 commits into
Open
GH-49465: [CI][C++] Fix Abseil hang in arrow-flight-test on ODBC Windows#50085tadeja wants to merge 6 commits into
tadeja wants to merge 6 commits into
Conversation
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
arrow-flight-testpasses all its subtests then intermittently hangs on exit and ctest kills it at the 300s timeout. The last thread was parked in Abseil's Windows sync primitiveWin32Waiterduring static destruction inside statically-linked gRPC. See upstream grpc/grpc#39321 and abseil/abseil-cpp#1877What changes are included in this PR?
For the ODBC Windows CI job: build gRPC (via the x64-windows-no-absl-sync vcpkg overlay triplet) and Arrow (via ARROW_CXXFLAGS) with GPR_DISABLE_ABSEIL_SYNC, so both use native Windows sync instead of
absl::Mutex. Remove once fixed upstream.Are these changes tested?
Yes, on fork CI the ODBC Windows tests were re-run with
ctest --repeat until-fail:10(temporary, not part of this PR) - All tests exited successfully thereAre there any user-facing changes?
No.