Repository navigation
test(rust): run miri tests - #4861
Merged
Merged
Conversation
lidavidm
added a commit
to lidavidm/arrow-adbc
that referenced
this pull request
Oct 7, 2026
- Use & instead of &mut to avoid violating borrowing rules - Use Mutex to ensure even misbehaved clients don't violate safety - Use Mutex to also provide interior mutability - Some minor refactoring Depends on apache#4861. Assisted-by: GPT-6 Astra
lidavidm
added a commit
to lidavidm/arrow-adbc
that referenced
this pull request
Oct 7, 2026
- Use & instead of &mut to avoid violating borrowing rules - Use Mutex to ensure even misbehaved clients don't violate safety - Use Mutex to also provide interior mutability - Some minor refactoring Depends on apache#4861. Assisted-by: GPT-6 Astra
lidavidm
force-pushed
the
miri
branch
3 times, most recently
from
October 8, 2026 23:00
a9b2496 to
9fcb408
Compare
lidavidm
marked this pull request as ready for review
October 8, 2026 23:41
Depends on apache#4858. Closes apache#4857.
lidavidm
added a commit
to lidavidm/arrow-adbc
that referenced
this pull request
Oct 9, 2026
- Use & instead of &mut to avoid violating borrowing rules - Use Mutex to ensure even misbehaved clients don't violate safety - Use Mutex to also provide interior mutability - Some minor refactoring Depends on apache#4861. Assisted-by: GPT-6 Astra
eitsupi
approved these changes
Oct 9, 2026
eitsupi
left a comment
eitsupi
left a comment
Collaborator
There was a problem hiding this comment.
Non-blocking: I'd love to see Miri coverage gradually expanded to more driver-manager tests and other platforms, especially Windows, where feasible.
lidavidm
added a commit
to lidavidm/arrow-adbc
that referenced
this pull request
Oct 9, 2026
- Use & instead of &mut to avoid violating borrowing rules - Use Mutex to ensure even misbehaved clients don't violate safety - Use Mutex to also provide interior mutability - Some minor refactoring Depends on apache#4861. Assisted-by: GPT-6 Astra
lidavidm
added a commit
to lidavidm/arrow-adbc
that referenced
this pull request
Oct 9, 2026
- Use & instead of &mut to avoid violating borrowing rules - Use Mutex to ensure even misbehaved clients don't violate safety - Use Mutex to also provide interior mutability - Some minor refactoring Depends on apache#4861. Assisted-by: GPT-6 Astra
lidavidm
added a commit
to lidavidm/arrow-adbc
that referenced
this pull request
Oct 9, 2026
- Use & instead of &mut to avoid violating borrowing rules - Use Mutex to ensure even misbehaved clients don't violate safety - Use Mutex to also provide interior mutability - Some minor refactoring Depends on apache#4861. Assisted-by: GPT-6 Astra
lidavidm
added a commit
that referenced
this pull request
Oct 11, 2026
- Use & instead of &mut to avoid violating borrowing rules - Use Mutex to ensure even misbehaved clients don't violate safety - Use Mutex to also provide interior mutability - Some minor refactoring Depends on #4861. Assisted-by: GPT-6 Astra
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #4858.
Closes #4857.