Repository navigation
fix(rust/ffi): avoid undefined behavior in exported drivers - #4871
Merged
Merged
Conversation
lidavidm
force-pushed
the
unsafe-export
branch
from
October 7, 2026 06:32
22f9189 to
27b020a
Compare
lidavidm
force-pushed
the
unsafe-export
branch
from
October 7, 2026 06:54
27b020a to
456766f
Compare
lidavidm
force-pushed
the
unsafe-export
branch
from
October 9, 2026 00:45
456766f to
ba3bb9a
Compare
Member
Author
|
Note this PR is stacked, you're best off choosing only the last commit for review! |
lidavidm
force-pushed
the
unsafe-export
branch
from
October 9, 2026 00:53
ba3bb9a to
6f7d897
Compare
- Use & instead of &mut to avoid violating borrowing rules - Use Mutex to ensure even misbehaved clients don't violate safety - Use Mutex to also provide interior mutability - Some minor refactoring Depends on apache#4861. Assisted-by: GPT-6 Astra
lidavidm
force-pushed
the
unsafe-export
branch
from
October 9, 2026 01:59
6f7d897 to
ab605bc
Compare
lidavidm
marked this pull request as ready for review
October 9, 2026 01:59
eitsupi
approved these changes
Oct 10, 2026
lidavidm
added a commit
that referenced
this pull request
Oct 12, 2026
Stacked on #4871. Assisted-by: GPT-6.1 Sol
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #4861.
Assisted-by: GPT-6 Astra