Skip to content

Fix flaky test_adjust_maintenance_mode_based_on_sysinfo_exit #69738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
FrankYang0529 wants to merge 1 commit into
base: main
Choose a base branch
from
+12 −0
Open

Fix flaky test_adjust_maintenance_mode_based_on_sysinfo_exit #69738

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions providers/edge3/tests/unit/edge3/cli/test_worker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,6 +164,18 @@ def setup_parser(self):
importlib.reload(cli_parser)
self.parser = cli_parser.get_parser()

@pytest.fixture(autouse=True)
def reset_maintenance_state(self):
# EdgeWorker keeps runtime state in class attributes and some tests set them
# on class level. Reset before each test so state does not leak between tests.
EdgeWorker.maintenance_mode = False
EdgeWorker.maintenance_comments = None
try:
yield
finally:
EdgeWorker.maintenance_mode = False
EdgeWorker.maintenance_comments = None

@pytest.fixture
def cli_worker_with_team(self, tmp_path: Path) -> EdgeWorker:
test_worker = EdgeWorker(str(tmp_path / "mock.pid"), "mock", None, 8, team_name="team_a")
Expand Down