Fix flaky test_adjust_maintenance_mode_based_on_sysinfo_exit#69738
Open
FrankYang0529 wants to merge 1 commit into
Open
Conversation
Signed-off-by: PoAn Yang <payang@apache.org>
Lee-W
approved these changes
Jul 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
EdgeWorker.maintenance_mode/maintenance_commentsare class attributes. Thetest_heartbeatsetEdgeWorker.maintenance_mode = Trueon class level and doesn't cleanup.pytest -n auto, so test order is dynamic.test_heartbeatruns right beforetest_adjust_maintenance_mode_based_on_sysinfo_exit, the leakedTruemakestest_adjust_maintenance_mode_based_on_sysinfo_exitfail.How
reset_maintenance_statefixture toTestEdgeWorkerthat resetsEdgeWorker.maintenance_mode/EdgeWorker.maintenance_commentsbefore each test, and after it.Sample Failed Run
Was generative AI tooling used to co-author this PR?
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.