Revert "Suspend Apache Beam Provider due to grpcio limitation (#61926)" - #66952
Conversation
3fbd131 to
01bc19c
Compare
|
@olegkachur-e A few things need addressing before review — see our Pull Request quality criteria.
No rush. Note: This comment was drafted by an AI-assisted triage tool and may contain mistakes. Once you have addressed the points above, an Apache Airflow maintainer — a real person — will take the next look at your PR. We use this two-stage triage process so that our maintainers' limited time is spent where it matters most: the conversation with you. |
1647831 to
794fc1a
Compare
Thanks for your comment! I reevaluated this:
Given the risk is known, bounded, and time-limited, I think unsuspending now is reasonable rather than keeping users on a suspended provider for another release cycle. We already accept unmaintained transitive dependencies elsewhere in the tree on a case-by-case basis; this one at least has a concrete removal date. Of course, if there's a vunlerability found and 2.76 is yet to be released - we could resume the suspension. @olegkachur-e Could you please resolve conflicts? |
I don't understand. what is the request? Before I write my thoughts there should be an explanation from beam mantainers why can't they just do another release? Shifting the risk to Airflow, however minimal, is a big ask. This goes way beyond just Beam. The desicion that will be taken here will be used as precedence for all the 100+ providers we have. |
Again, Beam needs to explain why they can't do out of release schedule to mitigate. Airflow is doing ad hoc releases when needed. I assume beam can do that too. To clarify, this is not a desicion we can take here. This must go to mailing list for visability. For exmaple, who decide what is resonable time? Is 1 month resonable? 3? What happens if beam break the commitment... We can't really rollback. Sometimes the things we expect don't work as much. We know this very well. Releases are delayed. Releases are yanked. |
An adhoc release would require you to set the upper bound to I agree that depending on 'beta' doesn't have great optics but beyond optics per se, i don't see an actual risk (i.e. vulnerability or introducing bugs). Arguably that was Beam's fault, that ship has sailed and we learned from it, it was not Airflow's fault and you are not adding this dependency intentionally. would it be ok for Airflow to add a constraint Beam can do out-of-calendar releases but this is a nontrivial amount of work and the bar for that is high (for example an urgent dataloss issue or smth like log4j vulnerability that everyone was scrambilng to mitigate asap). During the entire project lifetime that happened perhaps 2 or 3 times . |
I'd argue they are beam users as well :) |
|
to clarify: what is the risk for Airflow you'd like address ? If we look at the lock file, there are other dependencies that are no longer released, and whose last release was even before the pinned betterproto release. Is the word 'beta' in the name the only risk here? |
It's not a word. It is a declaration. The mantainers of this lib marked it as not suitable for production. No new releases since 2024. |
We actually don't depend on this dep directly in Beam either, i am not sure how it came into the picture in this Airflow change, presumably to help with the dependency resolution, and a suggestion is to add constraints on envoy-data-plane instead if you must appease the resolver for some reason.
we are going into hypotheticals here, while there are real adverse effects for users of Airflow and Beam due to suspended provider that I'd rather focus on. Left a suggestion. |
8a4a569 to
a3007a3
Compare
c4b25b7 to
5b9e8f1
Compare
5b9e8f1 to
d066e34
Compare
|
Hello @gopidesupavan @potiuk , |
Hello @MaksYermak - sorry for not responding before - I've been sick/out of action for the last week or so and slowly getting back to regular involvement. I tried to see - similarly as @gopidesupavan to fix the dependency issue, but as @eladkal noted - fixing betterproto to 6 years old pre-release version is a bad idea. Really the issue is on beam side not ours, so it's up on them to fix it. Luckily - they already did - it just did not make it into 2.75.0 release in July and it is planned to be released at the beginning of August. And this is the right way of solving the problem - and opens the way to un-suspend beam provider - making any workarounds on our side is just not something we should accept - especially that there is a fix in sight. You can read more details in here, where I wrote message to the dev team of Apache Beam: https://lists.apache.org/thread/lnm2gszq3lvqxgz70rms7zqmr757w5ol So - at this stage, what we need to do is to wait until 2.76.0 is released by Apache beam. Once this is done (+3 days cooldown on our side) - you should just rebase/resolve issues, bump min version for it pyproject.toml of the beam provider and all issues should be solved. I think a good idea for you might be to respond to that message if you feel that Beam team should speed it up a bit maybe - explaining how much needed it is by the composer team - and Google customers. Yes. I know it's frustrating, but it's really not something we should fix or workaround here. |
d066e34 to
772c223
Compare
772c223 to
ea6af13
Compare
…#61926)" This reverts commit 917abea. - Remove hacks regarding the beam provider suspension, as they are not relevant anymore. ISSUE: apache#66551
ea6af13 to
cd2840d
Compare
|
I think I fixed the issue - rebased and provided a fixup. |
…#61926)" (apache#66952) * Revert "Suspend Apache Beam Provider due to grpcio limitation (apache#61926)" This reverts commit 917abea. - Remove hacks regarding the beam provider suspension, as they are not relevant anymore. ISSUE: apache#66551 * fixup! Revert "Suspend Apache Beam Provider due to grpcio limitation (apache#61926)" * fixup! Revert "Suspend Apache Beam Provider due to grpcio limitation (apache#61926)" --------- Co-authored-by: Oleg Kachur <kachur@google.com> Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
This reverts commit 917abea.
Was generative AI tooling used to co-author this PR?
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.Important
🛠️ Maintainer triage note for @olegkachur-e · by
@potiuk· 2026-07-02 17:46 UTCSome review feedback from
@eladkalis waiting on you:@eladkalneed a reply or a fix.The ball is in your court — you've been assigned to this PR. Reply or push a fix in each thread, then mark them resolved.
Automated triage — may be imperfect; a maintainer takes the next look.