Conversation
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide
|
Member
|
this must wait for #66952 |
r3wretrhy
force-pushed
the
fix-beam-async-no-shell
branch
from
September 9, 2026 00:59
dff9c46 to
145d86c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BeamAsyncHookstarted pipeline processes by joining the argv list with POSIXshlexquoting and running the result through a shell. The sync hook already usessubprocess.Popenwithshell=Falseand the original list. The async path could therefore split interpreter or pipeline paths that contain spaces, especially on Windows where POSIX quoting is not what the shell expects.This runs
_beam_versionandrun_beam_command_asyncwithasyncio.create_subprocess_execso each argument stays one argv entry. Missing interpreters still raiseAirflowException. Tests assert exec is used (not shell) and that an argument containing spaces survives a live process.Was generative AI tooling used to co-author this PR?
Generated-by: Grok following the guidelines
pythonverification ofrun_beam_command_asyncwith a spaced argument, exec-vs-shell construction, and_beam_versionerror wrapping. Full provider suite via CI:providers/apache/beam/tests/unit/apache/beam/hooks/test_beam.py.