Skip to content

Add ConnectionResponse serializer safeguard #63883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pierrejeambrun merged 1 commit into from
Mar 23, 2026
Merged

Add ConnectionResponse serializer safeguard #63883

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions airflow-core/src/airflow/api_fastapi/core_api/datamodels/connections.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,8 +60,13 @@ def redact_extra(cls, v: str | None) -> str | None:
redacted_dict = redact(extra_dict)
return json.dumps(redacted_dict)
except json.JSONDecodeError:
# we can't redact fields in an unstructured `extra`
return v
# Do not return un-redacted extra because this could cause sensitive information to be exposed.
# This code path should never been hit as ``Connection._validate_extra`` sure that ``extra`` is
# always a valid JSON string. We add this safeguard just in case and to make the coupling
# explicit.
raise ValueError(
"This code path should never happen as persisted Connections (DB layer) should always enforce `extra` as a JSON string."
)


class ConnectionCollectionResponse(BaseModel):
Expand Down
Loading