Skip to content

Add ConnectionResponse serializer safeguard#63883

Open
pierrejeambrun wants to merge 1 commit intoapache:mainfrom
astronomer:add-connection-response-safeguard-for-non-json-string
Open

Add ConnectionResponse serializer safeguard#63883
pierrejeambrun wants to merge 1 commit intoapache:mainfrom
astronomer:add-connection-response-safeguard-for-non-json-string

Conversation

@pierrejeambrun
Copy link
Member

@pierrejeambrun pierrejeambrun commented Mar 18, 2026

This adds a safeguard and makes the code intent less confusing. It would be easy to assume that this could 'leak' some sensitive data if the extra wasn't a valid JSON. (But the DB layer guarantee this). Instead of relying on that db layer implicitly, make the coupling explicit.


Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)

  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

@pierrejeambrun pierrejeambrun force-pushed the add-connection-response-safeguard-for-non-json-string branch from 0344664 to 8d6fce3 Compare March 18, 2026 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:API Airflow's REST/HTTP API

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant