Repository navigation
Bound gateway checks of unknown signers and limit messages at the edge - #24
Merged
Merged
Conversation
… allowance, and limits messages per client address at the edge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A message signed with a key the gateway has not seen costs the node an operator lookup before it can be refused. This puts one shared bound on those lookups, keeps known operators outside it, and lowers the edge rate for messages.
Changes
operatorsview, read at start and everyOPERATORS_REFRESH_INTERVAL(60 s), plus signers found to be operators since the last read. A failed read keeps the previous list.NEW_SIGNER_CHECKS_PER_MINUTE(120 a minute, bursts of 10). Past it, a message answers503before the node is asked.RateLimitertakes an optionalburst.Verified
bun run check: typecheck clean, 265 tests pass, with new cases for the shared allowance, listed operators, learned operators, refresh failure and an empty list.nomad job run -outputon Nomad 1.10.5.