Repository navigation
Refuse no-op operator settings and limit them per hour - #25
Merged
Merged
Conversation
…at staking-rewards would refuse, and limits each per operator per hour.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Set-Delegate and Set-Share messages that would change nothing, or that the contract would refuse, no longer reach the node, and each action is limited per operator per hour.
Changes
Set-Delegatetakesaddressandsharetogether, or neither to reset. The contract ignores an address without a share and resets on a share without an address.409without reaching the node for a change to the current delegate and share, a reset with no delegate, and a share equal to the current one or the pending one.403forSet-Sharewhile staking-rewards has shares or operator share setting turned off.SETTINGS_CHANGES_PER_SIGNER_PER_HOUR(6) per signer and action, counted only once the signer passes the operator check.Verified
bun run check: typecheck clean, 274 tests pass, with new cases for each refusal, a share-only delegate change, the current share while another is pending, the hourly limit and non-operators.