Skip to content

security: remove fake credential encryption #3951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Tednoob17 wants to merge 1 commit into from
Closed

security: remove fake credential encryption #3951

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 2 additions & 21 deletions github-actions/bazel/configure-remote/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,8 @@
load("@devinfra_npm//:defs.bzl", "npm_link_all_packages")
load("//tools:defaults.bzl", "copy_to_bin", "esbuild_checked_in", "js_binary", "ts_project")
load("//tools:defaults.bzl", "esbuild_checked_in", "ts_project")

npm_link_all_packages()

copy_to_bin(
name = "gcp_token",
srcs = ["gcp_token.data"],
)

ts_project(
name = "setup-bazel-remote-exec",
srcs = glob(["*.ts"]),
Expand All @@ -18,23 +13,9 @@ ts_project(
],
)

js_binary(
name = "encrypt",
data = [":setup-bazel-remote-exec"],
entry_point = ":encrypt.js",
)

esbuild_checked_in(
name = "configure-remote",
srcs = [
":gcp_token",
":setup-bazel-remote-exec",
],
config = {
"loader": {
".data": "binary",
},
},
srcs = [":setup-bazel-remote-exec"],
entry_point = "index.ts",
format = "iife",
platform = "node",
Expand Down
12 changes: 10 additions & 2 deletions github-actions/bazel/configure-remote/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,19 @@ inputs:
google_credential:
description: |
A Google credential to be used as authentication for RBE API usages
required: true
trusted_build:
default: false
description: |
Whether the environment should be considerd a trusted build.

runs:
using: 'node24'
main: 'configure-remote.js'
using: composite
steps:
- run: node $GITHUB_ACTION_PATH/configure-remote.js
env:
BAZELRC: ${{ inputs.bazelrc }}
ALLOW_WINDOWS_RBE: ${{ inputs.allow_windows_rbe }}
TRUSTED_BUILD: ${{ inputs.trusted_build }}
GOOGLE_CREDENTIAL: ${{ inputs.google_credential }}
shell: bash
Loading