You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Fixes recoverable production credentials (GCP, BrowserStack, SauceLabs) by removing fake AES-256-GCM encryption whose key was derivable from the public org name.
Delete committed .data credential files and encrypt.ts
Replace bundled JS with minimal ESM scripts that read credentials from env
Update action.yml inputs to accept secrets from GitHub Actions
Mark required inputs and pass them as env vars in composite action steps
Restore BUILD.bazel targets without encrypted blob references
Add test verifying no hardcoded keys or encrypted blobs remain
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request refactors the GitHub Actions for Bazel remote execution, BrowserStack, and Sauce Labs to accept credentials directly via action inputs and environment variables, removing the previous embedded encrypted credential files and decryption logic. A new test script, test-credentials.mjs, is also added to verify that no encrypted files or hardcoded crypto constants are reintroduced. Feedback suggests quoting the script paths in the composite action files to prevent word-splitting issues on paths with spaces, and improving the test script to provide a clearer error message if no compiled JS files are found.
The reason will be displayed to describe this comment to others. Learn more.
Quote the script path to prevent word splitting and execution failures if the runner's workspace path contains spaces (e.g., on certain self-hosted runners or Windows environments).
The reason will be displayed to describe this comment to others. Learn more.
Quote the script path to prevent word splitting and execution failures if the runner's workspace path contains spaces (e.g., on certain self-hosted runners or Windows environments).
The reason will be displayed to describe this comment to others. Learn more.
Quote the script path to prevent word splitting and execution failures if the runner's workspace path contains spaces (e.g., on certain self-hosted runners or Windows environments).
The reason will be displayed to describe this comment to others. Learn more.
If no JS files are found in the action directory, the test will fail with a generic 'No process.env usage found' error. Consider explicitly checking if the JS files array is empty and pushing a more descriptive error message to help developers identify that the build outputs are missing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes recoverable production credentials (GCP, BrowserStack, SauceLabs) by removing fake AES-256-GCM encryption whose key was derivable from the public org name.
.datacredential files andencrypt.tsaction.ymlinputs to accept secrets from GitHub ActionsBUILD.bazeltargets without encrypted blob references