feat: group the board by host and paint it at once - #9
Draft
tensorcopy wants to merge 12 commits into
Draft
tensorcopy wants to merge 12 commits into
tensorcopy wants to merge 12 commits into
Conversation
- the lock still said 0.5.0 while package.json says 1.0.1
- a shared budget went to whichever relation held the newest items, so a full review queue pushed the viewer's own work off the board
- nodes(ids:) caps at 100 ids; ask in batches of that size so a longer board keeps its checks
- match the pull request each active or retained workspace tracks to the first agent created there, the originating conversation - an action on the row and in the panel jumps straight to that chat
- resolve the hostname from GH_HOST or the plugin's settings file and set it on every gh subprocess
- gh auth status names every authenticated host and its active account - item ids carry their host, so reads and actions reach the host that owns the item - the sweep unions every host's columns and keeps each host's failure in the column error
- one section per host when more than one host contributed, in the order the sort puts their first card - an expired login on one host no longer blanks the board for the hosts that are fine - an expired board is served immediately, marked stale, and refreshed behind the surface
- the board ttl drops to one minute, a sweep with a failed column is not cached, and the client refetches a stale answer
- the allowlist names no host itself: github.com plus the hosts gh auth status reports, all under /user-attachments/ only - an enterprise attachment is fetched with that host's own token via gh auth token --hostname - the githubusercontent CDNs carry the github.com token, never an enterprise one, and the signed redirect leg carries no header at all - the host list rides the board answer, so the client knows which urls the daemon will fetch
- changelog entries under unreleased for the ported features and fixes - readme gains the host, chat and freshness paragraphs, and the image limitation names the hosts the daemon will fetch for
- the settings-file hostname key was read but never written or documented, and the next settings save silently erased it - GH_HOST in the daemon environment is the documented override, and the sweep itself sets each host's context
- a refused hop carries no header; a githubusercontent hop carries the github.com token, those CDNs being github.com's own image hosting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why. With several hosts on one board the lists interleaved. Opening the surface waited on a full GitHub sweep. A board could sit minutes behind GitHub. And an enterprise repository's screenshots rendered as links, because the image proxy only knew github.com.
What.
staleon the wire, and refreshed behind the surface, and the client refetches a stale answer shortly after. The TTL drops to one minute, and a sweep in which a column failed is not cached. The header says how old the board on screen is.gh auth token --hostname). The allowlist names no host itself:github.complus the hostsgh auth statusreports, all under/user-attachments/only. The githubusercontent CDNs carry the github.com token — those CDNs being github.com's own image hosting — and a hop the allowlist refuses, such as the signed redirect leg, carries no header at all: a presigned URL answers 400 to a request that also carries an Authorization header, verified against a live attachment. An enterprise token never leaves its own host.GH_HOSTalone: a settings-filehostnamekey was read but never written or documented, and the next settings save silently erased it.[Unreleased], and the README paragraphs and limitation updates that match.How.
client/board/host-sections.tsgroups already-sorted rows without disturbing the order within a group; theCacheclass inserver/cache/gainedrevalidate,shouldCacheandpatchAll;shared/image-host.tstakes the authenticated hosts as a parameter and both halves pass the same list — the daemon from its accounts, the client from the board answer'simageHostsfield.Test. 14 suites, 70 tests at this tip, covering the cache revalidation and freshness, the host sections, the allowlist and the per-host token mapping. Typecheck and lint are clean, and every commit in the stack builds and passes its tests on its own.