fix(board): spend the search limit per relation, batch the checks - #6
Open
tensorcopy wants to merge 3 commits into
Open
tensorcopy wants to merge 3 commits into
tensorcopy wants to merge 3 commits into
Conversation
- the lock still said 0.5.0 while package.json says 1.0.1
- a shared budget went to whichever relation held the newest items, so a full review queue pushed the viewer's own work off the board
- nodes(ids:) caps at 100 ids; ask in batches of that size so a longer board keeps its checks
This was referenced Sep 28, 2026
Author
|
Hi @alysnnix! 👋 I've been running a fork of this plugin for a few weeks and accumulated some changes I'd like to give back. They're cut into a small series so each piece is reviewable on its own:
Everything passes typecheck, lint and the test suite on every commit, and each PR body follows the repo's conventions as I read them. No rush at all — and happy to rework, re-cut, or drop anything that doesn't fit where the project is going. Thanks for the plugin, Alysson — it's been a great base to build on. 🙂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why. The search limit was one shared budget across every relation, so a full review queue — whose items are the most recently updated — took the whole list and pushed the viewer's own work off a board that exists to show it. Checks assumed the merged list always fit a single
nodes(ids:)request.What.
limititems, and the union keeps whatever any relation kept.attachChecksasks in batches of 100 ids, so a longer board keeps its checks; one failed batch costs its own pills, not every other batch's.package.json(they still said 0.5.0), as a chore commit of their own.How.
mergeBucketResultsinserver/board/buckets.tscollects the kept ids per relation after the merge, so an item any relation kept survives;server/board/checks.tswalks the id list inCHECKS_BATCHslices.Test.
server/board/buckets.test.tsgains the per-relation budget cases. Typecheck and the suite pass at this tip: 56 tests. Every later commit in this stack also builds and tests on its own, checked commit by commit.