Skip to content

Fix crash when boolean flags are set via pyproject.toml #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Qrytics wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix crash when boolean flags are set via pyproject.toml #107

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions deadcode/actions/parse_arguments.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,6 +225,9 @@ def parse_arguments(args: list[str] | None) -> Args:
for key, item in parse_pyproject_toml().items():
if key not in parsed_args:
continue
if isinstance(parsed_args[key], bool):
parsed_args[key] = bool(item)
continue
if isinstance(item, str) and isinstance(parsed_args[key], list):
item = [item]
parsed_args[key].extend(item)
Expand Down
13 changes: 13 additions & 0 deletions tests/cli_args/test_parsing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,6 +238,19 @@ def test_sys_argv_used_when_no_arguments_provided(monkeypatch: pytest.MonkeyPatc
assert args.count is True


def test_boolean_pyproject_setting_enables_flag(tmp_path, monkeypatch: pytest.MonkeyPatch):
# Having
(tmp_path / 'pyproject.toml').write_text('[tool.deadcode]\nfix = true\ncount = true\n')
monkeypatch.chdir(tmp_path)

# When
args = parse_arguments(['foo.py'])

# Then
assert args.fix is True
assert args.count is True


def test_unknown_pyproject_setting_is_ignored(tmp_path, monkeypatch: pytest.MonkeyPatch):
# Having
(tmp_path / 'pyproject.toml').write_text('[tool.deadcode]\nunknown_setting = true\n')
Expand Down