Repository navigation
Conversation
Setting a boolean flag such as fix, dry, quiet, count or verbose under [tool.deadcode] crashed with AttributeError because the pyproject merge path unconditionally called list.extend on the parsed value. Boolean flags are now assigned instead of extended.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Setting a boolean flag such as
fix,dry,quiet,countorverboseunder[tool.deadcode]inpyproject.tomlcrashed the toolwith
AttributeError: 'bool' object has no attribute 'extend'instead of enabling the flag.
The pyproject merge path in
parse_argumentsunconditionally calledlist.extend()on the parsed CLI value, which is aboolforflag options. Boolean flags from
pyproject.tomlare now assignedinstead of extended; list options behave exactly as before.
Reproduce (before fix):
After the fix the run enables
fixand completes normally.Includes a regression test
(
tests/cli_args/test_parsing.py::test_boolean_pyproject_setting_enables_flag)that enables
fixandcountvia apyproject.tomlin a temporarydirectory: it fails with
AttributeErrorbefore the fix and passesafter it. Full suite: no new failures versus the pre-existing
baseline (48 pre-existing environment failures, identical with and
without this change; the touched test file passes 18/18).