[ThoSap]

Fixes #89

DatabaseReconciler, SchemaReconciler and RoleReconciler returned UpdateControl.noUpdate() when the PostgreSQL object already matched the spec. The reconcile did not write the status, so a PENDING or ERROR phase stayed after its cause went away. On a test cluster, 21 resources showed PENDING for 40 days after a short outage of their ClusterConnection, although each reconcile logged "up-to-date".

What changed

1. The "up-to-date" branch writes the status. It sets READY, clears the message and returns UpdateControl.patchStatus(resource), as GrantReconciler, DefaultPrivilegeReconciler and ClusterConnectionReconciler already do, and as the Garage Operator does.
2. lastProbeTime and observedGeneration are written on each reconcile. Before, noUpdate() also dropped them. After a spec change that needed no SQL statement, observedGeneration stayed at the old generation.
3. New tests for all six resources. Database, Schema, Role, Grant and DefaultPrivilege point clusterRef to a missing ClusterConnection, so the operator sets PENDING, and then point it back. ClusterConnection changes its port to a closed port, so the operator sets ERROR, and then restores it. Each test expects READY at the end.

Consequences

• Each reconcile now does one status write, also when nothing changed. This happens at each resync and at each restart. generation-aware: true filters the status events, so the write does not start a new reconcile.
• An "up-to-date" reconcile clears the message. A message such as "Database owner changed [...]" stays only until the next reconcile.

Checks that CI cannot do

• Without the fix in the three reconcilers, the new Database, Schema and Role tests fail. Each one times out when clusterRef points back, because observedGeneration is never written. The new Grant, DefaultPrivilege and ClusterConnection tests guard behavior that was already correct.

Related

• Database and Schema without an owner go to ERROR on the second reconcile #90: a Database or Schema without owner goes to ERROR on its second reconcile. The new Database and Schema tests set an explicit owner to avoid this bug. This PR does not fix it.

Other changes

• var where the same type is inferred, and formatting of a few test files. These changes do not change the behavior.