Repository navigation
Set the Role status to ERROR when its password Secret is missing - #94
Merged
Merged
Conversation
Assisted-by: Claude:claude-opus-5-5
ThoSap
force-pushed
the
fix-role-error-status-on-missing-password-secret
branch
from
October 25, 2026 15:10
4284cf6 to
c7e7bda
Compare
ERROR when its password Secret is missing
Assisted-by: Claude:claude-opus-5-5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RoleReconcilerread the password Secret before thetryblock. If the Secret was missing or had the wrong type,getSecretRefCredentialsthrew outside thetry, sohandleErrordid not run. The Role kept its old phase, for exampleREADY, andobservedGenerationstayed at the old generation, while each reconcile failed until JOSDK stopped the retries. The other five reconcilers do all their work inside thetryand setERRORin this case.Found in the review of #91. It is the same type of bug as #89.
What changed
tryblock. A missing or invalid Secret now setsERRORwith the message, for exampleSecret reference not found [...], and the operator tries again after 60 seconds. When the Secret appears, the Secret event source still starts a reconcile at once.READYRole pointspasswordSecretRefto a missing Secret and must go toERROR. Then it points back to the existing Secret and must go toREADY.Checks that CI cannot do
RoleReconciler, the new test fails: the status is never written, so the wait forobservedGenerationtimes out.