[Chore] Unskip VS Code e2e replay for subtasks#94
Conversation
|
No actionable issues found. See task
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
9f0ddd1 to
c31a59a
Compare
|
I see some merge conflicts here. Working on them now... |
879e0e8 to
2a54c07
Compare
|
I see some merge conflicts here. Working on them now... |
77052fc to
fa293b2
Compare
|
I see some merge conflicts here. Working on them now... |
fa293b2 to
c946c38
Compare
|
I see some merge conflicts here. Working on them now... |
|
I see some merge conflicts here. Working on them now... |
895516b to
ca06a86
Compare
ca06a86 to
7de61e6
Compare
f62a72d to
9aedf31
Compare
|
Addressed the three open review threads and pushed the follow-up in d5d5ae3. The shipped diff now keeps the subtasks probe on the same cancelled child task, captures that resumed child's final Validation on the pushed head is clean: |
ce66323 to
909d5b8
Compare
909d5b8 to
d1d3a2a
Compare
What problem this solves
Fixes an issue where the
subtasksVS Code e2e replay still missed the cancelled-child resume path, which left delegated cancellation behavior under-covered and could let a cancelled child reopen its parent when it later finished.Why this change was made
This keeps the test on the same cancelled child, validates the actual follow-up tool results in replay mode, teaches mock mode how the resumed child re-asks the follow-up, and detaches a user-cancelled delegated child from the parent it was previously blocking before that child is rehydrated.
AttemptCompletionToolmirrors that detach with an idempotency guard so a cancelled-then-resumed child whose parent is no longer awaiting it falls through to the normal completion-ask flow instead of delegating back into the parent.User impact
No direct UI change. The subtasks replay suite now catches delegated cancellation regressions, and a cancelled delegated child can finish without reviving the parent task it was cancelled out of.
Related PRs