[Chore] Unskip VS Code e2e replay for use_mcp_tool#93
Merged
Conversation
Contributor
Author
|
No actionable issues found. See task
|
This was referenced May 13, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
f491acd to
9fa41b7
Compare
Contributor
Author
|
I see some merge conflicts here. Working on them now... |
Contributor
Author
|
I see some merge conflicts here. Working on them now... |
Contributor
Author
|
Resolved merge conflicts in:
Warnings:
|
9f0ddd1 to
c31a59a
Compare
Contributor
Author
|
Addressed the remaining PR feedback on 77052fc22.
Validation:
Browser proof is not applicable here because this is test-only e2e fixture work. |
879e0e8 to
2a54c07
Compare
77052fc to
fa293b2
Compare
fa293b2 to
c946c38
Compare
edelauna
approved these changes
May 19, 2026
Contributor
edelauna
left a comment
There was a problem hiding this comment.
Unskipping existing e2e tests to increase coverage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem this solves
Fixes an issue where the
use_mcp_toolVS Code e2e suite still stayed skipped, which left MCP filesystem delegation unverified in the deterministic replay flow.Why this change was made
This slice rewrites the skipped MCP suite around stable fixture tags embedded in real prompts, dynamic fixture registration, and a real filesystem MCP server wired into the temporary test workspace. It also pins the filesystem MCP server package and keeps the error-path assertions focused on MCP behavior instead of brittle assistant phrasing.
User impact
No direct product behavior changes. The MCP e2e coverage becomes replayable and helps catch regressions in the MCP delegation path earlier.
Related PRs